Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Full support for Node.js 20 #4001

Open
Water-Melon opened this issue Nov 10, 2024 · 4 comments
Open

[feature] Full support for Node.js 20 #4001

Water-Melon opened this issue Nov 10, 2024 · 4 comments
Labels
status:triage Issue that has not been triaged type:feature New feature or request

Comments

@Water-Melon
Copy link

Hi team,

I hope you're doing well. I wanted to inquire if there are any plans for a new release. We've recently bumped the actions to avoid the dependency on Node.js 16, but some actions in version 2.0.0 still rely on it.

Looking forward to hearing from you!

@Water-Melon Water-Melon added status:triage Issue that has not been triaged type:feature New feature or request labels Nov 10, 2024
@ramonpetgrave64
Copy link
Collaborator

Hey, Yes we're planning to also upgrade the actions to use node20. We would also welcome a PR.

@Water-Melon
Copy link
Author

Water-Melon commented Jan 22, 2025

I noticed that the action on the main branch, as well as the other actions it uses, are already based on Node 20, so only the next version release is needed. Since Node 16 will reach end of life in the Actions runner, I think releasing the next version is quite necessary.

https://github.blog/changelog/2024-09-25-end-of-life-for-actions-node16/

Although the actions in v2.0.0 of slsa-github-generator are already based on Node 20, some of the other actions they use still depend on Node 16. For example: https://github.com/slsa-framework/slsa-github-generator/blob/v2.0.0/.github/workflows/builder_container-based_slsa3.yml#L309.

@saisatishkarra
Copy link
Contributor

@ramonpetgrave64 Is there any ETA on the release with the support for Node20?

@ramonpetgrave64
Copy link
Collaborator

Currently it takes about a week to do a proper release procedure. For now, I'll estimate to begin in the week of Feb 3.

@ramonpetgrave64 ramonpetgrave64 mentioned this issue Jan 27, 2025
5 tasks
ramonpetgrave64 added a commit that referenced this issue Jan 28, 2025
# Summary

start using node22 in all our actions and pre-submits.
re: #4001

## Testing Process

The pre-submits in this PR should pass.

## Checklist

- [x] Review the contributing
[guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [ ] Update documentation if applicable.
- [x] Add unit tests if applicable.
- [ ] Add changes to the
[CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
if applicable.

---------

Signed-off-by: Ramon Petgrave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:triage Issue that has not been triaged type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants