Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db.create(String, String, String, options) is hard to read #5

Open
Raynos opened this issue Feb 15, 2020 · 1 comment
Open

db.create(String, String, String, options) is hard to read #5

Raynos opened this issue Feb 15, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@Raynos
Copy link
Contributor

Raynos commented Feb 15, 2020

I don't know what the three strings do.

Can we change the API to db.create(tableName: string) for the simple case and

db.create(options: {
  tableName: string,
  hash: string,
  range: string,
  createOptions: object
})
@heapwolf
Copy link
Member

heapwolf commented Feb 15, 2020

that works for me. the reason I did it the way I did was to not mix options for this library and options that are forwarded to the sdk function

We could have two params. One our options, and then second positional could be their options

@jwerle jwerle added good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants