FluentQuery.page(Pagable pagable) does not consider Pageable.sort

[Mrakobec]

it possible to implement the method fluentQuery.page(Pageble pagable) for automatically call sortBy(Sort sort) if pagable.sort is not null?

[mp911de]

As per our Javadoc:

pageable - the pageable to request a paged result, can be Pageable.unpaged(), must not be null. The given Pageable will override any previously specified sort if the Sort object is not Sort.isUnsorted(). Any potentially specified limit(int) will be overridden by Pageable.getPageSize().

So we expect that Pageable.sort takes precedence over any previously configured Sort if Pageable is sorted.

Care to elaborate what Spring Data module and which API (Querydsl, Specifications, Query by Example) you're using?

[mp911de]

We need to strengthen our Sort override. With the original Pageable used for subsequent pagination, we should not apply a previous Sort set on the fluent query as subsequent Page requests would use Pageable.sort when using Page.nextPageable().

[Mrakobec]

Amazing! Thank you a lot!
Am I correct in seeing that I can specify only .page() for <S extends T, R> R findBy(Specification<T> spec, Function<FluentQuery.FetchableFluentQuery<S>, R> queryFunction), and the sorting will be applied? Additionally, if there was a .sortBy() specified, it will be overridden if sorting is present in the pageRequest?

Examples:

1. Explicitly specifying .sortBy() before .page():

   public Page<ExampleEntity> findAll(Specification<ExampleEntity> filters, PageRequest pageRequest) {
       return voucherRepository.findBy(filters, fetchable ->
               fetchable.project("someAttribute")
                       .sortBy(pageRequest.getSort()) 
                       .page(pageRequest));
   }

2. Only specifying .page() without .sortBy():

   public Page<ExampleEntity> findAll(Specification<ExampleEntity> filters, PageRequest pageRequest) {
       return voucherRepository.findBy(filters, fetchable ->
               fetchable.project("someAttribute")
                       .page(pageRequest));
   }

[mp911de]

Yes, that's right. We entirely override any previous sortBy(…) once a Pageable parameter is given.