Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git SHAs are detected as AWS Secret Access Keys #587

Closed
danbarr opened this issue Jan 14, 2025 · 1 comment
Closed

Git SHAs are detected as AWS Secret Access Keys #587

danbarr opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels

Comments

@danbarr
Copy link
Contributor

danbarr commented Jan 14, 2025

Describe the issue

Git SHAs and AWS Secret Access Keys match the same regex pattern. Unfortunately I don't think anything but the proposed enhancements to secrets detection context will solve for this, but documenting anyway.

For example, the uses line in this GitHub Actions workflow is being detected/alerted as an AWS secret:

    steps:
      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

Steps to Reproduce

Add a Git SHA reference in a file or prompt. CodeGate will alert about a detected AWS secret:

Amazon - Secret Access Key:

steps:
- uses: REDACTED<$K0JvoN3DmtK4KOHLFj681lbvkYV5u7kpaD6tYAZBJbVpnrXuZ/SRllg4BdiRjibBXQQfisfuDqKaWJArQVviJgQCysgF+xllc1Gb4htk/RJEjE+rH2yK8HySckVKXwfO> # v4

Operating System

MacOS (Arm)

IDE and Version

VS Code 1.96.3

Extension and Version

GitHub Copilot 1.257.0

Provider

GitHub Copilot

Model

Any

Logs

No response

Additional Context

No response

@yrobla
Copy link
Contributor

yrobla commented Jan 21, 2025

@danbarr i actually removed the recognition of secret access key, because it was messing with other outputs as well. For example, it was obfuscating paths or just simple strings with 40 char length. As it was giving lots of false positives and messing with the llm responses, i dropped it.
So it should not be an issue anymore, can you confirm?

@lukehinds lukehinds assigned lukehinds and poppysec and unassigned lukehinds Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants