Error code 128

[flavio-schoute]

Hi I get this kind of error:

Run stefanzweifel/git-auto-commit-action@v5
  with:
    commit_message: Apply php-cs-fixer changes
    branch: ci-cd-improvements
    file_pattern: .
    repository: .
    commit_user_name: github-actions[bot]
    commit_user_email: 41898[2](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:2)82+github-actions[bot]@users.noreply.github.com
    commit_author: flavio-schoute <[email protected]>
    skip_dirty_check: false
    skip_fetch: false
    skip_checkout: false
    disable_globbing: false
    create_branch: false
    internal_git_binary: git
Started: bash /home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/entrypoint.sh
INPUT_REPOSITORY value: .
INPUT_STATUS_OPTIONS: 
INPUT_FILE_PATTERN: .
INPUT_BRANCH value: ci-cd-improvements
From https://github.com/plug-and-pay/sdk-php
 * [new branch]      dependabot/composer/phpunit/phpunit-tw-11.[3](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:3) -> origin/dependabot/composer/phpunit/phpunit-tw-11.3
 * [new branch]      dependabot/composer/symfony/var-dumper-tw-7.1 -> origin/dependabot/composer/symfony/var-dumper-tw-7.1
 * [new branch]      feature/INTEG-2[5](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:5)5-checkout-entity -> origin/feature/INTEG-255-checkout-entity
 * [new branch]      hotfix/set-tax-id -> origin/hotfix/set-tax-id
 * [new branch]      main              -> origin/main
fatal: invalid reference: ci-cd-improvements
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:17:19)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:1[6](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:6))
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 128
}
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v5/index.js:1[7](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:7):19)
    at ChildProcess.emit (node:events:519:2[8](https://github.com/plug-and-pay/sdk-php/actions/runs/11143670123/job/30969263942#step:8:8))
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)
    

I don't know how this fix this kind of issue.

I work on PR that is open-source. Link to the PR

[stefanzweifel]

Hi @flavio-schoute

Thanks for reporting.
This error is related to a known problem when the action is used in public repositories. (We have some documentation for this, which would be intended for the maintainer of the project your contributing to)

In your specific case the problem looks like this:

• The plug-and-pay/sdk-php starts an action
• In the action run, the plug-and-pay/sdk-php repository is checked out with a token that is associated with your user
• The php-cs-fixer workflow is run and potential files are changed
• The git-auto-commit action tries to create a branch in the plug-and-pay/sdk-php repository with a token associated with your user. Your user probably doesn't have the permission to do this. And the changes should also be pushed into your fork repository in flavio-schoute/sdk-php

As mentioned in the docs, if possible we suggest running linter/fixers on the main-branch to prevent this problem in the first place.

However, the project you're working on could use the pull_request_target-trigger to accomplish this. But also mentioned in the docs: This can lead to a potential security risk as mentioned by the GitHub security team itself.

The updated workflow would look like this

name: Run tests & format

on:
  workflow_dispatch:
  pull_request:
+ pull_request_target:
  push:
    branches:
      - main

jobs:
  test:
    name: Run tests
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v4

      - uses: nanasess/setup-php@master
        with:
          php-version: 8.1

      - name: Install Dependencies
        run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress

      - name: Composer dump-autoload
        run: composer dump-autoload

      - name: Execute tests (Unit and Feature tests) via PHPUnit
        run: vendor/phpunit/phpunit/phpunit Tests

  format:
    name: Fix PHP Coding Style
    runs-on: ubuntu-latest
+   permissions:
+     contents: write

    steps:
      - uses: actions/checkout@v4
        with:
+         # Checkout the fork/head-repository and push changes to the fork.
+         # If you skip this, the base repository will be checked out and changes
+         # will be committed to the base repository!
+         repository: ${{ github.event.pull_request.head.repo.full_name }}

+         # Checkout the branch made in the fork. Will automatically push changes
+         # back to this branch.
+         ref: ${{ github.head_ref }}

      - uses: nanasess/setup-php@master
        with:
          php-version: 8.1

      - name: Install Dependencies
        run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress

      - name: Composer dump-autoload
        run: composer dump-autoload

      - name: Run php-cs-fixer
        run: ./vendor/bin/php-cs-fixer fix

      - uses: stefanzweifel/git-auto-commit-action@v5
        with:
          commit_message: Apply php-cs-fixer changes