Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to improve the style of the buttons? #2609

Open
xdvi opened this issue Oct 15, 2024 · 3 comments
Open

Is it possible to improve the style of the buttons? #2609

xdvi opened this issue Oct 15, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers who want to improve the library waiting for the user's answer

Comments

@xdvi
Copy link

xdvi commented Oct 15, 2024

It is possible to improve the styling of the buttons by adding internal padding. Also, it would be better to implement a smoother hover effect without the focus ring, instead of using a ring when focusing, and reduce slightly the padding-right

{7F1CA8B8-0E9E-4AEE-90C6-D44741B71B2C}

@stephanrauh
Copy link
Owner

Yeah, sure. What about this: you fix the layout in your global styles.css until you're satisfied and send me the result. If it passes my checks, I'll add it to the CSS code of ngx-extended-pdf-viewer.

Alternatively, you can fix it in https://github.com/stephanrauh/ngx-extended-pdf-viewer/blob/main/projects/ngx-extended-pdf-viewer/src/lib/theme/common/viewer-with-images.scss and send me a pull request.

@stephanrauh stephanrauh assigned stephanrauh and xdvi and unassigned stephanrauh Oct 15, 2024
@stephanrauh stephanrauh added good first issue Good for newcomers who want to improve the library waiting for the user's answer labels Oct 15, 2024
@xdvi
Copy link
Author

xdvi commented Dec 27, 2024

Hi @stephanrauh,

I'm sorry for the delay in responding. Unfortunately, I haven't been able to run the project successfully on my local machine. Could you please guide me on how I can make the necessary changes to the CSS while being able to visualize the results? Any help would be greatly appreciated!

@stephanrauh
Copy link
Owner

And now I'm responding late... The build instructions are here:
https://github.com/stephanrauh/ngx-extended-pdf-viewer/blob/main/projects/ngx-extended-pdf-viewer/how-to-build.md

I hope they're up-to-date. If something's missing, don't hesitate to tell me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers who want to improve the library waiting for the user's answer
Projects
None yet
Development

No branches or pull requests

3 participants
@stephanrauh @xdvi and others