Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Severe gif encoding bug #15

Open
mjphaynes opened this issue Jan 23, 2020 · 2 comments
Open

Severe gif encoding bug #15

mjphaynes opened this issue Jan 23, 2020 · 2 comments

Comments

@mjphaynes
Copy link

There is a bug here:

$byte |= (ord($this->firstFrameBytes[10]) & 0x07);

See here for correct logic: https://github.com/lunakid/AnimGif/blob/master/src/GifCreator/AnimGif.php#L361

This causes gifs to be corrupted in certain situations

@marrone
Copy link

marrone commented Jan 27, 2020

I have an issue with corrupted gifs as well, but the linked code looks comparable. I think the issue is elsewhere, but I've not found it yet

@mjphaynes
Copy link
Author

Yeah this could be your issue as well as this is a pretty major flaw in the logic.

I don't know if this package is still maintained? If it is I could submit a pull request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants