Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Full screen toggle for Android tablets #566

Open
ransur0t opened this issue Jan 23, 2025 · 6 comments
Open

[FEATURE] Full screen toggle for Android tablets #566

ransur0t opened this issue Jan 23, 2025 · 6 comments
Labels
enhancement New feature or request

Comments

@ransur0t
Copy link

Is your feature request related to a problem?

Due to lack of full screen mode for Chrome browser on Android, unable to toggle reader to use full screen.

Describe the solution you'd like

Toggle for full screen mode in Stump web reader.

Describe alternatives you've considered

Haven't explored alternative browsers yet to see if they support full screen mode on Android.

Additional context

Issue created in response to Discord support chat!

@ransur0t ransur0t added the enhancement New feature or request label Jan 23, 2025
@RileyMathews
Copy link

I have a similar feature request with ios devices. I think that the 'add to home screen' provided by safari on iOS could be used for this as other self hosted apps (specifically thinking of mealie) do this where once added to the home screen then opening the app there opens in a full screen window with no browser decorations. I would assume that mealie works the same on android so this could maybe be a cross platform solution? When I try the same thing with my self hosted stump website then clicking the app icon that is created just opens the website back in the default browser app. I wish I knew more about frontend dev to say how this is done but either way having a similar ability in stump to be able to hide browser decorations and get true fullscreen mode while reading would be amazing!

@aaronleopold
Copy link
Collaborator

I think that the 'add to home screen' provided by safari on iOS could be used for this as other self hosted apps

I think this might be a different request, but honestly I'm not sure. I've definitely used this feature on my phone, but I haven't had a web app which doesn't just open in my default browser. A cursory glance led me here, so perhaps it is possible.

Hopefully by 2026 though a proper PoC mobile app can be more developed

aaronleopold added a commit that referenced this issue Jan 23, 2025
This enables a more seamless "Add to Home Screen" experience on iOS. See #566 (comment)
aaronleopold added a commit that referenced this issue Jan 23, 2025
This enables a more seamless "Add to Home Screen" experience on iOS. See #566 (comment)
@aaronleopold
Copy link
Collaborator

@RileyMathews The latest nightly build should have the meta tag that enables this, if you'd like try it out. If it doesn't work as expected, or you have follow-up questions, I'd say lets open a different issue.

@RileyMathews
Copy link

That seemed to work at first but then after moving to view the detail page for a book the embedded safari browser controls came up and I couldn't figure out how to get rid of them... so not sure what is going on there. If you want to move this issue into another thread I would be up for that. And if you don't have the energy to put into researching it right now I can try to work on myself. I'm not a frontend expert but have done enough that I feel I could figure it out given enough time.

@aaronleopold
Copy link
Collaborator

Ah alright, yeah I probably should have tested it more but was eating lunch. Taking another look, it looks like the controls pop up whenever you navigate anywhere.

If you want to move this issue into another thread I would be up for that. And if you don't have the energy to put into researching it right now I can try to work on myself.

Yeah let's create another issue to capture any further discussions around this, and if you have the time / energy to try and look into figuring out what might be happening I'd definitely appreciate it! No worries if not, I'll try to get to it at some point

@ransur0t
Copy link
Author

ransur0t commented Jan 24, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants