Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace references to talon.grammar.[vm.]Phrase by list[str] #1731

Open
nriley opened this issue Feb 3, 2025 · 1 comment
Open

Replace references to talon.grammar.[vm.]Phrase by list[str] #1731

nriley opened this issue Feb 3, 2025 · 1 comment
Labels
blocked-0.5

Comments

@nriley
Copy link
Collaborator

nriley commented Feb 3, 2025

Per aegis, "folks probably shouldn't be using talon.grammar.* imports".

In current betas, you can use list[str] instead of Phrase, but we can't make this change yet because we still support 0.4.
@auscompgeek
Copy link
Collaborator

Would Sequence[str] also be valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-0.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nriley @auscompgeek