Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Areabrick Overview] translation keys for name will not be translated #31

Closed
mike4git opened this issue Oct 22, 2024 · 3 comments · Fixed by #36
Closed

[Areabrick Overview] translation keys for name will not be translated #31

mike4git opened this issue Oct 22, 2024 · 3 comments · Fixed by #36

Comments

@mike4git
Copy link
Collaborator

We have introduced names of AreaBricks by translated keys and in the overview:
image

So the overviewtable should use translations where possible and sensible:

  • name
  • description
@jdreesen
Copy link
Member

We could just translate the given strings. This would also translate Video Dispatcher, for example. I don't know if this is desirable. Otherwise, we would have to somehow determine which strings should be translated.

@mike4git
Copy link
Collaborator Author

But Pimcore itself works with the same technique for class definitions for example.
So the translation of Video Dispatcher is an expectable behaviour.
It depends on your project if you respect translation technique or not...

As I already stated I would provider translation technique for name and description and offer the possibility to give areabricks a customer-specific (and translated) name.

@mike4git
Copy link
Collaborator Author

I've offered a PR if you are convinced: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants