Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible misconfiguration with rules and serviceMonitor #311

Open
jmtt89 opened this issue Sep 6, 2023 · 0 comments
Open

Possible misconfiguration with rules and serviceMonitor #311

jmtt89 opened this issue Sep 6, 2023 · 0 comments

Comments

@jmtt89
Copy link

jmtt89 commented Sep 6, 2023

on kube-thanos-rule.libsonnet

...
            containers: [c] +
                        (
                          if std.length(tr.config.rulesConfig) > 0 || std.length(tr.config.extraVolumeMounts) > 0 || tr.config.alertmanagerConfigFile != {} || tr.config.remoteWriteConfigFile != {} then [
                            reloadContainer,
                          ] else []
                        ),
...
  serviceMonitor: 
      endpoints: [
        ...
        { port: 'reloader' },
...

when I don't include any of the fields: rulesConfig, extraVolumeMounts, alertmanagerConfigFile or remoteWriteConfigFile, the 'reloader' port is still included on ServiceMonitor, but I don't go to anywhere because the reloadContainer is not included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant