Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should metadata be valid if it contains keytypes/schemes that client is unfamiliar with? #65

Open
jku opened this issue Jul 15, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented Jul 15, 2024

This relates to tests added in 0a81fc1: the test assumes that root should be considered valid by a client even if it contains keytypes/schemes that the client does not recognise (this assumes the signing threshold of root is still reached with the keys that it does understand)

The spec does not seem to really say anything about this. The argument against considering metadata like this valid are that

  • it's hard to imagine a realistic scenario where this would happen in the real world (meaning a situation where accepting metadata with unknown keys would lead to a functioning TUF client update: typically if keys are added to metadata, they are also required for verifying signatures...)
  • A client silently doing nothing with keys that it does not understand sounds like a potential for bugs later on

I'm filing this issues because I plan to remove the test for now: let's figure out what the correct behaviour is first and re-add them (or some simpler tests) afterwards if needed.

jku added a commit to jku/tuf-conformance that referenced this issue Jul 15, 2024
It's not clear what the correct behaviour is in these tests:
See issue theupdateframework#65

Signed-off-by: Jussi Kukkonen <[email protected]>
@AdamKorcz
Copy link
Contributor

Related to theupdateframework/python-tuf#2669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants