Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect @ts-expect-error comment causes TypeScript error #5592

Open
2 tasks done
EricImpact opened this issue Jan 10, 2025 · 0 comments · May be fixed by #5593
Open
2 tasks done

Incorrect @ts-expect-error comment causes TypeScript error #5592

EricImpact opened this issue Jan 10, 2025 · 0 comments · May be fixed by #5593
Labels

Comments

@EricImpact
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

When I upgraded to the latest versions of the Uppy packages we're using, I hit a roadblock due to TypeScript errors in @uppy/core, which are breaking my builds.

Expected behavior

Builds should be successful.

Actual behavior

TypeScript errors break the build:

Screenshot 2025-01-10 at 10 22 58 am

The first one is from this unused @ts-expect-error directive. There are two other TypeScript errors in this file on lines 902 and 914

@EricImpact EricImpact added the Bug label Jan 10, 2025
@EricImpact EricImpact linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant