Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.py broken in r24.11 #7939

Open
prm-james-hill opened this issue Jan 15, 2025 · 0 comments
Open

build.py broken in r24.11 #7939

prm-james-hill opened this issue Jan 15, 2025 · 0 comments

Comments

@prm-james-hill
Copy link

prm-james-hill commented Jan 15, 2025

Description

This works:

git clone [email protected]:triton-inference-server/server.git
git checkout r24.10
python3 build.py

But after doing git checkout r24.11 or git checkout r24.12 and rerunning build.py I get the following error:

[ 18%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/_c/tritonfrontend_pybind.cc.o
[ 18%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/common.cc.o
[ 20%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/classification.cc.o
[ 22%] Building CXX object python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o
In file included from /workspace/src/classification.cc:27:
/workspace/src/classification.h:31:10: fatal error: triton/core/tritonserver.h: No such file or directory
   31 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:104: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/classification.cc.o] Error 1
gmake[5]: *** Waiting for unfinished jobs....
In file included from /workspace/src/shared_memory_manager.cc:27:
/workspace/src/shared_memory_manager.h:33:10: fatal error: triton/core/tritonserver.h: No such file or directory
   33 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:76: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/shared_memory_manager.cc.o] Error 1
In file included from /workspace/src/common.cc:27:
/workspace/src/common.h:37:10: fatal error: triton/core/tritonserver.h: No such file or directory
   37 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:90: python/tritonfrontend/CMakeFiles/py-bindings.dir/__/__/common.cc.o] Error 1
/workspace/src/python/tritonfrontend/_c/tritonfrontend_pybind.cc:40:10: fatal error: triton/core/tritonserver.h: No such file or directory
   40 | #include "triton/core/tritonserver.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[5]: *** [python/tritonfrontend/CMakeFiles/py-bindings.dir/build.make:118: python/tritonfrontend/CMakeFiles/py-bindings.dir/_c/tritonfrontend_pybind.cc.o] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:831: python/tritonfrontend/CMakeFiles/py-bindings.dir/all] Error 2
gmake[4]: *** Waiting for unfinished jobs....

Triton Information
r24.11 is the first version I see this behavior in.

To Reproduce
See above description. I also tried with various tag and backend options but it didn't impact it. (EDIT: After enabling 90% of options it appears to work. I don't know which option is providing this header or fixing the include, though.) I'm on Ubuntu 24.04.

Expected behavior
Build script to finish without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant