Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cosmetic filtering be removing simple text links? #6923

Closed
bughit opened this issue Feb 4, 2020 · 3 comments
Closed

Should cosmetic filtering be removing simple text links? #6923

bughit opened this issue Feb 4, 2020 · 3 comments

Comments

@bughit
Copy link

bughit commented Feb 4, 2020

URL(s) where the issue occurs

w3ctag/design-reviews#467 (comment)

Describe the issue

The above github comment contains a link to doubleclick.net (to illustrate chrome's x-client-data header), which becomes unclear when the link is removed.

What is the upside of removing text links? I don't want to disable cosmetic filtering entirely, because presumably it removes something like large obnoxious ad sections. But then it should be less aggressive and leave simple text links alone.

Screenshot(s)

[Screenshot(s) for difficult to describe visual issues are mandatory. Post links instead of Inline Images for Screenshots containing Adult material.]
image

image

Versions

  • Browser/version: Fx 72.0.2
  • uBlock Origin version: 1.24.2

Settings

  • [List here all the changes you made to uBO's default settings]

Notes

[Add here the result of whatever investigation work you have done: please investigate the issues you report -- this prevents burdening other volunteers. This is especially true for issues arising from settings which are very different from default ones.]

@uBlock-user
Copy link
Contributor

uBlock-user commented Feb 4, 2020

It's not a text link, the link is parsing the url to https://ad.doubleclick.net/ which is an ad server and gets hidden by Easylist's generic filter -- ##a[href^="https://ad.doubleclick.net/"]. Generic filter can be disabled on github.

@mapx-
Copy link
Contributor

mapx- commented Feb 4, 2020

just add
@@||github.com^$ghide

@bughit
Copy link
Author

bughit commented Feb 4, 2020

No doubt it can be worked around, however I am suggesting that cosmetic filtering should be blocking large obnoxious block content. There is not sufficient justification to remove inline text links. The downside is greater than the upside. Why does a user need to be protected from seeing a text link to doubleclick?

@uBlockOrigin uBlockOrigin deleted a comment from krystian3w Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants