[NODRIVER] Bug with cdp.fetch.RequestPaused

[tikene]

When using cdp.fetch.RequestPaused, requests can be blocked as expected, unless Nodriver fails to find an element using tab.find. After that, the outgoing requests stop being blocked.

The requests still go through the handler and can be displayed in the console, but I am unable to block them in any way. I also tried using fail_request to no avail (although tbf I may have used that wrong). Posting this issue to save future headaches to fellow coders because this was very painful to debug, I imagine this is not expected behaviour @ultrafunkamsterdam

Here is sample code which demonstrates the issue, keep an eye on the blue .gif logo in the middle bottom of the website, which pops up after the second find() is executed, when it should be filtered:

import asyncio
from nodriver import cdp
import nodriver as uc

class Test():   
    async def requested_paused_handler(self, event: cdp.fetch.RequestPaused):
        r = event.request
        is_blocked = True if ".gif" in r.url else False
        if not is_blocked:
            asyncio.create_task(
                self.tab.send(
                    cdp.fetch.continue_request(request_id=event.request_id)
                )
            )
        else:
            s = f"BLOCKING | {r.method} | {r.url}"
            print(f" >>> ------------\n{s}")
            
    async def start_test(self):
        # Initialize browser
        self.browser = await uc.start()
        # Load blank page
        self.tab = await self.browser.get("about:blank")
        
        # Set up browser request filtering
        self.tab.add_handler(cdp.fetch.RequestPaused, self.requested_paused_handler)
        
        # Load website, the blue logo won't appear since it's been filtered
        self.tab = await self.browser.get('https://www.berkshirehathaway.com/')
        print("\nPage loaded")
        await asyncio.sleep(5)

        # This element exists in the test page
        print("\nAttempting to find existing element")
        await self.tab.find("A Message from Warren E. Buffett")
        print("Done!")
        await asyncio.sleep(5)
        
        # As soon as the find is called, the blue .gif logo appears in the page, and any further requests are not blocked
        print("\nAttempting to find non existant element")
        await self.tab.find("this element does not exist")
        
test = Test()
uc.loop().run_until_complete(test.start_test())

[tikene]

Managed to fix it using the following code, still curious about what could cause this behaviour but feel free to mark this issue as closed. Requests would show up as "pending" in the network tab until the find() was called

async def requested_paused_handler(self, event: cdp.fetch.RequestPaused):
        r = event.request
        is_blocked = True if ".gif" in r.url else False
        if not is_blocked:
            asyncio.create_task(
                self.tab.send(
                    cdp.fetch.continue_request(request_id=event.request_id)
                )
            )
        else:
            s = f"BLOCKING | {r.method} | {r.url}"
            print(f" >>> ------------\n{s}")
            asyncio.create_task(
                self.tab.send(
                    cdp.fetch.fail_request(event.request_id, cdp.network.ErrorReason.TIMED_OUT)
                )
            )

[devblack]

From this:
asyncio.create_task(self.tab.send(cdp.fetch.continue_request(request_id=event.request_id)))

To this:
self.tab.feed_cdp(cdp.fetch.continue_request(request_id=event.request_id))