Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better module hierarchy #10

Open
yyyliu opened this issue Feb 24, 2021 · 1 comment
Open

Need a better module hierarchy #10

yyyliu opened this issue Feb 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@yyyliu
Copy link
Member

yyyliu commented Feb 24, 2021

Now the boba and boba-visualizer modules depend on each other ...

The reason that boba depends on boba-visualizer is because we would like a single pip command to install all boba submodules.

The reason that boba-visualizer depends on boba is because the server needs to invoke boba run.

If we separate boba-dsl from boba, and make boba only a dummy module that imports everything else, we can get rid of circular dependency.

Also, I am not sure where to put the sampling code. Maybe we need another module like boba-stats.

@yyyliu yyyliu added the bug Something isn't working label Feb 24, 2021
@yyyliu
Copy link
Member Author

yyyliu commented Apr 25, 2021

boba no longer depends on boba-visualizer: uwdata/boba@88aebd9

Users now need to install these two packages separately via two commands, but it might be ok for now ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant