-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uptime is not sorted correct #440
Comments
The Fact section doesn't know anything about the data it's sorting on, it's all string sort. |
@mterzo, I have been trying to detect and convert uptime to string and them make sorting. Something like: day_search=/(days)/g; function sortNumber(a,b) { But still it doesn't work. What is wrong with the code? |
I have come the conclusion that @emlun007 is a troll account. |
Nope, @emlun007 is my coworker and not a troll. |
Yesterday someone was asking me about a device and they didn't know the hostname/IP. But it had recently been turned on. I started trying to look for recently turned on devices but the sort doesn't actually work. Then you get a little bit down the list and the page automatically refreshes. I definitely think this would be a good improvement but it won't be a small patch. Fact types would need to be classified by sort type and have classes added. I saw a PR that was trying to run regex on every fact to see if it was a type of date/time. I don't think that is a good way about going about it. |
@kirkins , it is definately not a small patch. I've been trying to make a class for ip addresses and it is a lot of work as I need to make changes in layout.html and marcos.html |
This is solved in PR 435: Closing the issue |
Why was this never merged? :( |
Uptime in facts is sorted alphabetically, and hours are treated as days:
I am trying to create a class for sorting but I cannot find the right way to capture the values in ('.dataTable td'). Any suggestions?
The text was updated successfully, but these errors were encountered: