Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toPath... functions should work in MonadThrow, right now they are unsafe! #9

Open
Martinsos opened this issue Oct 25, 2020 · 0 comments
Open

toPath... functions should work in MonadThrow, right now they are unsafe! #9

Martinsos opened this issue Oct 25, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@Martinsos
Copy link
Member

If StrongPath.Path contains ../, transforming it into Path.Path is not possible because Path.Path does not support ../, and right now error happens, which makes the function unsafe. Instead we should have it operate in the MonadThrow, same as Path.Path does in such situations.
@Martinsos Martinsos added enhancement New feature or request bug Something isn't working good first issue Good for newcomers labels Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martinsos