Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full path to call pwsh, since it is not in the path yet #815

Merged
merged 2 commits into from
May 16, 2024

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Feb 19, 2024

Resolves #814

Tried to test, but failed due to #813

@virzak virzak changed the title Use ful path to call pwsh, since it is not in the path yet Use full path to call pwsh, since it is not in the path yet Mar 18, 2024
@coolaj86
Copy link
Member

I'm trying to remember why I had the custom pkg_done_message here at all.

My guess is that it's to surface errors when dependencies (libraries) are missing, or the wrong binary is selected for the target machine.

Making a few modifications:

  • "$pkg_dst_cmd" must be quoted, otherwise Macs on Windows networks get errors when the Active Directory domain creates a space in the user's home directory. For example: /Users/John Smith/.local/opt/pwsh/pwsh
  • Nixing the "installed to" since we already have that in the new install script

Copy link
Member

@coolaj86 coolaj86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@coolaj86 coolaj86 merged commit 7b70ab8 into webinstall:main May 16, 2024
3 checks passed
@coolaj86
Copy link
Member

I was pretty sure that the command should be in the PATH by virtue of the installer's processing having it in its PATH.

So... I don't think this actually fixed anything. I think the real problem was Microsoft's change to the package internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install pwsh
2 participants