-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different results for v1.2.0 and v1.2.2 and v1.3.0 #74
Comments
Thank you very much for your report. In versions prior to v1.2.2, if the repeat count of a read at a given site was less than the minimum repeat count (which can be set via the command line), the read would be filtered out, which is an unreasonable operation. As shown in your screenshot, all these records added in v1.2.2 have genotypes with fewer than 10 repeats of A repeat. |
@Stikus |
We'll test v1.3.0 today, when we test it we got error about same genome for Thanks for detailed answer - I'll post v1.3.0 results here if you don't mind. |
I would be very grateful. Please feel free to post here. |
Can you help me with new naming? Before we have According to Line 40 in 35c39bb
|
Yes, to align with the results produced by the pro command, the _all table includes all microsatellite sites with sufficient coverage, while the _unstable table indicates unstable sites, meaning sites where somatic mutations have occurred. |
Here is a comparison (
As you can see - |
Yes, we removed the display of genotypes because many sites have undergone somatic mutations, making the genotypes here inaccurate. Additionally, for those sites, we adjusted the default minimum repeat count for homopolymers from 10 to 8, as in our experience, homopolymers with repeat counts of 8 and 9 also have many somatic mutations. The tab in the header is not as expected; I will remove it. |
Correct me if I'm wrong - all new lines (green on screen) have repeat count 8 or 9. But old lines have repeat counts 5,6,7 and 10,11,12. So - how we get 5,6,7 in results if default was lowered from 10 to 8? Upd. Or low repeat counts can be only for repeats with length more than one? So resulting length is above threshold? |
In the scan command, the -l and -r parameters control the minimum repeat count for single nucleotide repeats and other sites (where the repeat unit length is greater than 2), respectively. The default values for -l and -r are 8 and 5, respectively. |
Great thx for answers, we'll use latest version now. The issue can be closed, I think. FYI - we are using your tool with latest samtools without any problems with this patch before Our full build part from Dockerfile:
|
Thank you very much for providing the Docker file and for testing it. I will keep this issue open for a while; if you have any other questions, please feel free to post. |
Hello, thanks for updates for your tool.
We're trying to update our docker containers with your tool but registered different results for
v1.2.0
andv1.2.2
:Run commands:
First of all - number of sites and windows changed:
v1.2.0
:v1.2.2
:And more important - we have empty germline result now:
v1.2.0
:v1.2.2
:Is this intended? Is this due to
MinMicrosate
andMaxMicrosate
change in commit 3d3d7b8 ? Looks like now zero sites have enough coverage butcovCutoff
is same (15).The text was updated successfully, but these errors were encountered: