Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XMTP specific macro for cleaning up logs #1565

Open
insipx opened this issue Jan 29, 2025 · 0 comments
Open

Make XMTP specific macro for cleaning up logs #1565

insipx opened this issue Jan 29, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented Jan 29, 2025

we have lots of logs like this, esp in mls sync code:

                tracing::info!(
                    inbox_id = self.client.inbox_id(),
                    sender_inbox_id = sender_inbox_id,
                    installation_id = %self.client.installation_id(),sender_installation_id = hex::encode(&sender_installation_id),
                    group_id = hex::encode(&self.group_id),
                    current_epoch = mls_group.epoch().as_u64(),
                    msg_epoch,
                    msg_group_id,
                    msg_id,
                    "[{}] staged commit is valid, will attempt to merge",
                    self.context().inbox_id()
                );

they're useful when debugging, but add visual clutter to the code. we can instead create a super macro to reduce this to oneline

@insipx insipx added the enhancement New feature or request label Jan 29, 2025
@insipx insipx added this to libxmtp Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant