cannot handle line return inside closing tags #65

Akronae · 2024-03-04T09:14:09Z

With this example:

fn main() -> () {
    let str = r#"<!DOCTYPE html>
    <html>
      <body>
        <div>div 1</div>
        <div>div 2</div
        ><div>div 3</div>
        <div>div 4</div>
      </body>
    </html>
    "#;

    let dom = tl::parse(str, Default::default()).unwrap();
    let parser = dom.parser();
    let inner_html = dom
        .children()
        .get(1)
        .unwrap()
        .get(parser)
        .unwrap()
        .inner_html(parser)
        .to_string();

    dbg!(inner_html);
}

<body>
        <div>div 1</div>
        <div>div 2</div
        ><div>div 3</div>
        <div>div 4</div>
</body>

will be wrongly changed to

 <body>
    <div>div 1</div>
    <div>
        div 2
        <div>div 3</div>
        <div>div 4</div>
    </div>
</body>

Fixes y21#65 by adding a skip whitespace before and after the name of a closing tag. Also adds a test to verify that this functions properly, based on the example in y21#65. Note that the [HTML spec] does not allow for whitespace between the `</` and the tag name, although this is accepted by these changes to maintain symmetry with the parsing of the start of a tag which started allowing whitespace between `<` and the tag name in c532c72. [HTML spec]: https://html.spec.whatwg.org/multipage/syntax.html#end-tags

Akronae changed the title ~~cannot handle line return inside tags~~ cannot handle line return inside closing tags Mar 4, 2024

tslnc04 linked a pull request Apr 28, 2024 that will close this issue

Handle whitespace inside closing tags #67

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cannot handle line return inside closing tags #65

cannot handle line return inside closing tags #65

Akronae commented Mar 4, 2024

cannot handle line return inside closing tags #65

cannot handle line return inside closing tags #65

Comments

Akronae commented Mar 4, 2024