Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

[Feature Request] Validate inject_code path before trying to inject to a service #185

Closed
yafp opened this issue Apr 23, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@yafp
Copy link
Owner

yafp commented Apr 23, 2020

Is your feature request related to a problem? Please describe.
It could avoid problems if we would check if the path to an inject_file is valid before injecting it.

Describe the solution you'd like
check if path is valid / file exists

Describe alternatives you've considered

  • Dont try to inject it if path isnt valid
  • Report warning to user

Additional context
Might be related with #184

@yafp yafp added the enhancement New feature or request label Apr 23, 2020
@yafp yafp added this to the 1.9.0 milestone Apr 23, 2020
@yafp yafp self-assigned this Apr 23, 2020
@yafp
Copy link
Owner Author

yafp commented Apr 24, 2020

Question:
the relative inject code path in the serviceList is using linux path notation.
Is that properly handled on i.e. Windows Machines?

@yafp yafp closed this as completed Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant