Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Improved error handling for invalid JSON in global_config.json #1405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed: Improved error handling for invalid JSON in global_config.json #1405

wants to merge 1 commit into from

Conversation

sammamama
Copy link

Fixed #1404 . A dialog box error now pops up for the people with invalid JSON in their global_config,json file.

Fixes:
I changed the code to throw an error, whenever an error is caught while trying to read global_config.json file.

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (specify distro)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@alya
Copy link
Collaborator

alya commented Feb 4, 2025

Please clean up your commit history and post again to request a review. See here for guidelines.

I'm not sure why this PR is marked as a draft. In general, that is a signal that you don't want reviewers to look at it yet.

@sammamama
Copy link
Author

I'll clean up my commit history.

I marked this as Draft as I though it was part of the guidelines. But since I now know it is not, I'll make it a PR.

@sammamama sammamama marked this pull request as ready for review February 4, 2025 09:20
@alya
Copy link
Collaborator

alya commented Feb 5, 2025

Please update your commit message to match the commit style guidelines.

@sammamama
error handling: fix error handling when global_config.json is in inco…
398fa0a 
…rrect format

Fixes zulip#1404. I added a dialog box error function, that gets thrown whenever json format is found to be incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High size: S Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error handling for invalid JSON in global_config.json
3 participants
@sammamama @alya @zulipbot