Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Augmenter la taille de du pix-select afin de faire comprendre à l'utilisateur qu'il doit scroller lorsqu'il y a trop d'option (PIX-16230) #823

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Jeremiejade
Copy link
Contributor

@Jeremiejade Jeremiejade commented Feb 3, 2025

🎄 Problème

La dropdown du pix-select à une taille qui ne permet pas de comprendre qu'il faut scroll quand il y a beaucoup d'option.

🎁 Proposition

Augmenter la taille du dropdown afin de faire apparaître la moitié d'une option afin de faire comprendre à l'utilisateur qu'il doit scroll.

🌟 Remarques

RAS

🎅 Pour tester

Se rendre sur la documentation du pix-select et vérifier que la dernière option affichée nous invite à scroller.

@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr823.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr823/environment

@Jeremiejade Jeremiejade force-pushed the pix-16230-improve-dropdown-size branch from dac0f52 to a7c2d7a Compare February 3, 2025 15:27
@Jeremiejade Jeremiejade marked this pull request as draft February 3, 2025 16:00
@Jeremiejade Jeremiejade force-pushed the pix-16230-improve-dropdown-size branch from a7c2d7a to 0b30034 Compare February 3, 2025 16:05
@Jeremiejade Jeremiejade marked this pull request as ready for review February 3, 2025 16:28
Copy link
Contributor

@xav-car xav-car left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai une impression de "déjà vu" 😅

@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-16230-improve-dropdown-size branch from 0b30034 to a987e86 Compare February 7, 2025 09:28
@pix-service-auto-merge pix-service-auto-merge merged commit 794fa63 into dev Feb 7, 2025
7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-16230-improve-dropdown-size branch February 7, 2025 09:32
pix-service-auto-merge pushed a commit that referenced this pull request Feb 7, 2025
# [54.8.0](v54.7.0...v54.8.0) (2025-02-07)

### 🚀 Amélioration

- [#823](#823) Augmenter la taille de du pix-select afin de faire comprendre à l'utilisateur qu'il doit scroller lorsqu'il y a trop d'option (PIX-16230)
@pix-service-auto-merge
Copy link
Contributor

🎉 This PR is included in version 54.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants