Add a new condition to check the distance between an object and a position #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This increases the "surface of the API" of base objects. In other words: yet another condition in an already very (too?) big list of conditions. I think we need at some point to reorganize it or introduce some more grouping. cc @ClementPasteau @D8H |
|
I don't know how it can be reorganized. I'm not found of groups with 2 instructions. I guess the same thing could apply to this condition: |
D8H
reviewed
Jul 2, 2024
|
I've updated this PR with the suggested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815.
Game Example:
Add Distance Conditions.zip
Video
electron_p9lsOTt2uj.mp4