Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the indefinite loading state when there are no posts ✅ #252

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kareemabdeen
Copy link
Contributor

Description

This PR fixes the Discover Posts View Stuck on Loading issue where users were not receiving any feedback when no posts were available. Instead of an indefinite loading state, a "No Posts Yet" message is displayed.

Motivation & Context:

  • Users were left without feedback when the Discover screen had no posts.
  • The fix improves UX by providing clear visibility when no content is available.
  • Affects both mobile and web versions.

Type of Change

  • Bug Fix (Fixes an issue without breaking existing functionality)
  • New Feature (Adds a new, non-breaking feature)
  • Breaking Change (Existing functionality might not work as expected)
  • Refactor (Code improvements without affecting functionality)
  • Documentation Update (Changes related to documentation)

How Has This Been Tested?

Please describe the tests conducted to verify the fix. Include test steps for reproduction.

Test Cases:

  1. Scenario: No posts are available.
    • Expected Result: The "No Posts Yet" message is displayed instead of a loading spinner.
  2. Scenario: Posts are available.
    • Expected Result: Posts load correctly without unnecessary loading indicators.

Tested on:

  • Mobile (Android/iOS)
  • Web

📸 Screenshots (if applicable):
Before Fix
https://github.com/user-attachments/assets/2c9e3585-cc41-431d-86e3-e1a47e03af16
After Fix
https://github.com/user-attachments/assets/08f71108-df26-45a5-83d9-4000c5c455c4


Checklist

  • Code follows project style guidelines
  • Performed self-review of the code
  • Added comments where necessary
  • Made corresponding updates to documentation
  • No new warnings or errors generated
  • Added tests to verify the fix or feature works
  • Existing unit tests pass successfully
  • Merged and published any dependent changes

Maintainer Checklist

  • Closes issue #xxxx (Replace xxxx with the GitHub issue number)
  • Tagged PR with appropriate labels

@kareemabdeen kareemabdeen requested a review from jddeep as a code owner January 31, 2025 00:53
@kareemabdeen
Copy link
Contributor Author

Can you please review? 🙏🏼 @mdmohsin7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant