Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up deprecated items in api-mock of SDKs and protractor testing #2740

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

sdo-1A
Copy link
Contributor

@sdo-1A sdo-1A commented Jan 27, 2025

Proposed change

Cleanup of deprecated items in api-mock of showcase SDK and training SDK (and mustache file in @ama-sdk/schematics)

Related issues

- No issue associated -

@sdo-1A sdo-1A requested a review from a team as a code owner January 27, 2025 14:28
Copy link

nx-cloud bot commented Jan 27, 2025

View your CI Pipeline Execution ↗ for commit da0c760.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 1h 3m 26s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 9m 17s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 46s View ↗
nx affected --target=lint ✅ Succeeded 15m 26s View ↗
nx run-many --target=build ✅ Succeeded 15m 5s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 11m View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-29 11:34:34 UTC

fpaul-1A
fpaul-1A previously approved these changes Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.94%. Comparing base (3d57087) to head (da0c760).
Report is 2 commits behind head on release/12.0.0-next.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ages/@ama-sdk/core/src/clients/api-fetch-client.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdo-1A sdo-1A dismissed stale reviews from matthieu-crouzet and fpaul-1A via 880244a January 27, 2025 16:03
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch 2 times, most recently from 880244a to 40160e9 Compare January 27, 2025 16:04
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch from 40160e9 to e6c0e54 Compare January 28, 2025 08:55
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch from e6c0e54 to cf6bb8a Compare January 28, 2025 13:18
fpaul-1A
fpaul-1A previously approved these changes Jan 28, 2025
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch from cf6bb8a to 8167696 Compare January 28, 2025 14:21
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch from 8167696 to f40c9a5 Compare January 29, 2025 09:46
@sdo-1A sdo-1A changed the title feat: cleanup deprecated items in api-mock of SDKs feat: clean up deprecated items in api-mock of SDKs and protractor testing Jan 29, 2025
@sdo-1A sdo-1A force-pushed the feat/cleanup-deprecated branch from f40c9a5 to da0c760 Compare January 29, 2025 09:51
@sdo-1A sdo-1A merged commit b9fc0c0 into release/12.0.0-next Jan 29, 2025
35 of 36 checks passed
@sdo-1A sdo-1A deleted the feat/cleanup-deprecated branch January 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants