-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2758): set exact-o3r-version as default for all schematics if provided when adding @o3r/core #2769
base: release/11.6
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 6999941.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
834e15b
to
2c2b52c
Compare
@@ -94,6 +94,33 @@ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS | |||
IN THE SOFTWARE. | |||
|
|||
@o3r/new-version | |||
Copyright Amadeus SAS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be removed from the PR ?
5c3b77c
2c2b52c
to
5c3b77c
Compare
15d4baf
to
9de0ac9
Compare
c01bbe4
to
b8bef9b
Compare
346ae54
to
34e7a66
Compare
34e7a66
to
06653e4
Compare
…ovided when adding @o3r/core
06653e4
to
6999941
Compare
const schematicOptionsWithoutUndefined = Object.entries(options).reduce((acc: Record<string, any>, [key, value]) => { | ||
if (typeof value !== 'undefined') { | ||
acc[key] = value; | ||
} | ||
return acc; | ||
}, {}) as S; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const schematicOptionsWithoutUndefined = Object.entries(options).reduce((acc: Record<string, any>, [key, value]) => { | |
if (typeof value !== 'undefined') { | |
acc[key] = value; | |
} | |
return acc; | |
}, {}) as S; | |
const schematicOptionsWithoutUndefined = Object.fromEntries( | |
Object.entries(options) | |
.filter(([, value]) => typeof value !== 'undefined') | |
) as S; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed it in the team and half of them preferred the .reduce()
because we are not used to Object.fromEntries()
Related issues
--exact-o3r-version
withnpm create @o3r
,ng g library
fails if--exact-o3r-version
is not explicitly specified again #2758