Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected account portfolio defi fixes #1289

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from

Conversation

PetromirDev
Copy link
Member

@PetromirDev PetromirDev commented Feb 7, 2025

Changes and fixes:

  • Add: maxDataAgeMs to defiPositions
  • Fix: Selected account portfolio flashes with an incorrect balance because defiPositions have not loaded an isAllReady is set to true
  • Fix: skip hidden tokens in updatePortfolioStateWithDefiPositions
  • Fix: isDefiToken flag not added to defi tokens
  • Refactor: Don't reconstruct portfolio tokens in updatePortfolioStateWithDefiPositions

@PetromirDev PetromirDev added the bug Something isn't working label Feb 7, 2025
@PetromirDev PetromirDev self-assigned this Feb 7, 2025
onGasTank: false,
rewardsType: null
// @BUG: defi positions tokens can't be hidden and can be added as custom
// because processTokens is called in the portfolio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a link to this issue here: https://github.com/AmbireTech/ambire-app/issues/3971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants