Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment to clarify IMU acceleration value #29074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tuxliri
Copy link

@Tuxliri Tuxliri commented Jan 14, 2025

Clarifying IMU reading value, as noted in #29072.

@rmackay9
Copy link
Contributor

Hi @Tuxliri,

Txs for this. Could you update the commit title to prefix it with "SITL: "? We like to prefix all our commits with the subsystem or folder name where the change is made because it makes backporting easier. To be clear, I meant the commit title, not the PR title.

@Tuxliri Tuxliri force-pushed the doc/imu-acceleration-sitl branch from d3397c9 to f313d44 Compare January 15, 2025 10:29
@Tuxliri
Copy link
Author

Tuxliri commented Jan 15, 2025

@rmackay9 done!

@IamPete1
Copy link
Member

Did you find the readme? https://github.com/ArduPilot/ardupilot/blob/master/libraries/SITL/examples/JSON/readme.md Do you think we should add the clarification there too?

@Tuxliri
Copy link
Author

Tuxliri commented Jan 18, 2025

@IamPete1 this is example-specific so not related to the JSON protocol per-se. But it would be useful to add a section to the README with a description of the reference frames used and this could be an example there. I have written a Jupyter notebook to explain this (link), I can sum it up in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants