Move REQUIRE_POSITION_FOR_ARMING bit to AP_arming #29076
Conversation
while Copter is the only user at the moment, will be useful on Rover shortly
while Copter is the only user at the moment, will be useful on Rover shortly
while Copter is the only user at the moment, will be useful on Rover shortly
peterbarker
changed the title
| @@ -146,6 +146,7 @@ const AP_Param::GroupInfo AP_Arming::var_info[] = { | |||
| // @DisplayName: Arming options | |||
| // @Description: Options that can be applied to change arming behaviour | |||
| // @Bitmask: 0:Disable prearm display,1:Do not send status text on state change | |||
| // @Bitmask{Copter}: 0:Disable prearm display,1:Do not send status text on state change,2:Require position for arming | |||
There was a problem hiding this comment.
| // @Bitmask{Copter}: 0:Disable prearm display,1:Do not send status text on state change,2:Require position for arming | |
| // @Bitmask{Copter}: 0:Disable prearm display,1:Do not send status text on state change,2:Require location for arming |
There was a problem hiding this comment.
Why not add it to plane also?
There was a problem hiding this comment.
Plane already requires position for arming, all the time.
That's actually why we put this into Copter's flight options in the first place - we're going to have an awkward time when Plane no longer requires position for arming....
But we want this bit for Rover, so @rmackay9 asked for it to be moved (#29073)
There was a problem hiding this comment.
Thanks for this. I'm not sure we really needed to replace "position" with "location" but it's OK in either case.
More importantly I guess the reason we put it in FLIGHT_OPTIONS in the first place was because once someone sets this bit they will never get the default changes to the ARMING_OPTIONS parameter? that hardly seems like a good enough reason so I suspect I'm missing something
I should have taken better notes :-) |
... also rename it to
REQUIRE_LOCATION_FROM_ARMINGto be more in-line with ArduPilot's distinction between "position" (local position) and "location" (absolute lat/lng)