Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: useInstallPlugins() hook- Fix translations to account for localization. #41756

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

elliottprogrammer
Copy link
Contributor

@elliottprogrammer elliottprogrammer commented Feb 12, 2025

An Automattic repo member that works on our translations left a comment in one of my previous PR's, asking to update some strings to account for localization.
This PR applies those updates so that the strings can be better translated and account for localization.

Related to: #41013 (review)

Proposed changes:

  • Defined the singular and plural version of the string in 2 separate strings, which accounts for localization.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • I think it would be enough to simply inspect the code change and verify that the singular and plural version of the success message are defined separately and that change looks reasonable.

I've manually tested this PR, and if you would like to test it too, do the following:

  • Run this PR on a Jurassic Ninja site via the Jetpack Beta Plugin (run this branch on the Jetpack plugin).
  • Make sure Jetpack is connected (both site and user).
  • Purchase Jetpack Complete.
  • In My Jetpack you should see a Notice, suggesting to install Boost & CRM (See screenshot)
  • Screen Shot on 2025-02-12 at 11-58-47
  • Click the CTA to install both plugins.
  • In the top right corner, look for a Toast popout that says, "Plugins installed successfully!" Verify you see this Toast message. See screenshot:
  • Screen Shot on 2025-02-12 at 12-01-14
  • Now deactivate and uninstall the Boost plugin.
  • In My Jetpack you should see the Notice again, but suggesting to install only Boost this time.
  • Click the CTA to install Boost.
  • In the top right corner, look for a Toast popout that says, "Jetpack Boost installed successfully!" Verify you see this Toast message. See screenshot:
  • Screen Shot on 2025-02-12 at 12-04-38

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/use-install-plugins-translations branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/use-install-plugins-translations
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/_inc/data/products/use-install-plugins.ts 0/12 (0.00%) 0.00% 3 ❤️‍🩹

Full summary · PHP report · JS report

Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants