-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooling: Cursor rule cleanup #41786
base: trunk
Are you sure you want to change the base?
Tooling: Cursor rule cleanup #41786
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
@@ -18,4 +18,4 @@ The “Significance” header specifies the significance of change in the style | |||
The “Type” header categorizes the change in the changelog. In Jetpack, for example, our changelog divides changes into “Major Enhancements”, “Enhancements”, “Improved compatibility”, and “Bugfixes”. | |||
Type must be "security", "added", "changed", "deprecated", "removed", or "fixed" | |||
|
|||
The body is separated from the headers by a blank line, and is the text that actually goes into the changelog. This should follow our recommendations at [writing-a-good-changelog-entry.md](mdc:jetpack/jetpack/jetpack/docs/writing-a-good-changelog-entry.md). | |||
The body is separated from the headers by a blank line, and is the text that actually goes into the changelog. This should follow our recommendations at @docs/writing-a-good-changelog-entry.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem to work for me. Cursor seems to want that markdown link with that special mdc:
format. It doesn't recognize the link otherwise.
I'm not sure where that mulitple jetpack
comes from though ; when I create the link today I only get one jetpack
.
Cursor Rules seem like they're implemented oddly. You have to tell the agent to follow the rules for it to follow the rules by specifically bringing a rule into context. It sounds like they see the system as library where you can "check out" the rules that are needed and ignore the rest. Makes it a lot less useful than I was hoping, but alas. |
The Cursor rules appear to have recursion issues when attempting to reference another file (e.g.
jetpack/jetpack/jetpack/jetpack/jetpack/.github/versions.sh
is nonsense). This fixes those links and clarifies a few other items (e.g. coding standards are not identical to WP coding standards).Cursor's documentation has the following:
I've updated references to monorepo files to use the
@path/to/file
syntax; hopefully that's what it means. It doesn't seem Cursor has awareness of its own rules in the limited time I tried to ask it questions.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Do the changes make sense?