-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newsletter Widget: Render placeholder from Calypso app behind a constant #41807
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report Add label
I don't care about code coverage for this PR
|
*/ | ||
public static function load_admin_scripts( $asset_handle, $asset_name, $options = array() ) { | ||
$default_options = array( | ||
'config_data' => array(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config_data is currently empty, we can add what we want based on other widgets like Jetpack stats when we begin working on adding the functionality for the newsletter widget.
This PR renders a placeholder for the Newsletter widget. This happens by rendering the stadnalone app built in Calypso - Automattic/wp-calypso#99652.
This PR also adds feature checks on Jetpack, Simple and Atomic.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Jetpack/WOA sites.
define( 'JETPACK_NEWSLETTER_WIDGET', true );
to yourwp-config.php
file if you're testing this on local.For WOA sites, this constant can be set in the wp-config file which lives in a file like this
home/150782295/htdocs/wp-config.php
, essentially in your htdocs folder.Similarly for JN sites, you can do this in /srv/htdocs. Your JN site's wp-admin has the ssh creds you will need to update the
wp-config.php
file to set the JETPACK_NEWSLETTER_WIDGET constant.x.x.x.x is your sandbox's IP as usual.
JETPACK_NEWSLETTER_WIDGET
or ensure that it's set to false so you we be sure that the feature check is working.Simple sites
0-sandbox.php
, Add the constantdefine( 'JETPACK_NEWSLETTER_WIDGET', true );