Fix the Unknown instruction warning spam

That can occur when loading the script before starting the game.
It was caused by shaman shop rando patching too early.

Dolphin scripts/Entrance Randomizer/lib/shaman_shop.py

@@ -13,6 +13,12 @@
 MAPLESS_SHOP_PRICES = [0x04, 8, 16, 32, 0x00003, 4, 5, 10, 10, 10, 9, 7, 7, 8]
 """Same as `DEFAULT_SHOP_PRICES` but with 4 lowest prices removed."""
 
+SHOP_INITIALIZED_VALUE = 5
+"""
+The first value of the shaman_shop_struct once initialized.
+This represents the number of Canteen upgrades.
+"""
+
 
 class ShopPriceOffset(IntEnum):
     ExtraHealth1 = 4
@@ -48,10 +54,6 @@ class ShopCountOffset(IntEnum):
     MysteryItem = ShopPriceOffset.MysteryItem - 4
 
 
-_shaman_shop_prices = list(DEFAULT_SHOP_PRICES)
-_shaman_shop_prices_string = ""
-
-
 def randint_with_bias(
     a: int,
     b: int,
@@ -90,6 +92,10 @@ def randint_with_bias(
     raise ValueError(f"Invalid {direction=}.")
 
 
+_shaman_shop_prices = list(DEFAULT_SHOP_PRICES)
+_shaman_shop_prices_string = ""
+
+
 def randomize_shaman_shop():
     global _shaman_shop_prices, _shaman_shop_prices_string
     if ADDRESSES.shaman_shop_struct == TODO:
@@ -166,6 +172,9 @@ def randomize_shaman_shop():
 
 
 def patch_shaman_shop():
+    if (memory.read_u32(ADDRESSES.shaman_shop_struct) != SHOP_INITIALIZED_VALUE):
+        return ""
+
     if CONFIGS.DISABLE_MAPS_IN_SHOP:
         for offset in (
                 ShopCountOffset.JungleNotes,

Dolphin scripts/Entrance Randomizer/lib/utils.py

@@ -94,8 +94,6 @@ def prevent_transition_softlocks():
         and height_offset
     ):
         player_z_addr = follow_pointer_path((ADDRESSES.player_ptr, PlayerPtrOffset.PositionZ))
-        # memory.write_f32(player_x_addr, memory.read_f32(player_x_addr) + 30)
-        # memory.write_f32(player_y_addr, memory.read_f32(player_y_addr) + 30)
         memory.write_f32(player_z_addr, memory.read_f32(player_z_addr) + height_offset)
 
 

Dolphin scripts/Entrance Randomizer/newsfragments/+sham_shop_init.bugfix.md

@@ -0,0 +1 @@
+Fix the `Unknown instruction` warning spam that can occur when loading the script before starting the game -- by @Avasam