Instrument additional data points #7543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstantin-msft
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz,
Robbie-Microsoft,
lalimasharda and
shylasummers
as code owners
github-actions
bot
added
msal-browser
…d errors. - Instrument `system.asyncPopups` config param. - Instrument usage of loginHint, domainHint and SID.
konstantin-msft
force-pushed
the
instrument_additional_attributes
branch
from
05f5ebd to
da6dfe8
Compare
peterzenz
approved these changes
Jan 30, 2025
sameerag
approved these changes
Jan 30, 2025
tnorling
reviewed
Jan 30, 2025
tnorling
reviewed
Jan 30, 2025
| @@ -666,6 +666,19 @@ export class AuthorizationCodeClient extends BaseClient { | |||
| ); | |||
| } | |||
|
|
|||
| this.performanceClient?.addFields( | |||
| { | |||
| useLoginHint: parameterBuilder.hasParameter( | |||
There was a problem hiding this comment.
Would be useful to differentiate between UPN vs. claim if possible
tnorling
reviewed
Jan 30, 2025
tnorling
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system.asyncPopupsconfig param.