Skip to content

Commit

Permalink
fix: tooltip: wrap when content is unbroken long string (#5333)
Browse files Browse the repository at this point in the history
* fix: tooltip: wrap when content is unbroken long string

* Updating vdiff goldens (#5334)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
margaree and github-actions[bot] authored Jan 20, 2025
1 parent 708b6f7 commit 30e69e6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 3 additions & 1 deletion components/tooltip/test/tooltip.vdiff.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { styleMap } from 'lit/directives/style-map.js';

const shortText = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.';
const longText = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.';
const longTextNoSpaces = 'Loremipsumdolorsitamet,consecteturadipiscingelit,seddoeiusmodtemporincididuntutlaboreetdoloremagnaaliqua.';
const additionalText = 'Aliquam ut porttitor leo a diam sollicitudin tempor id eu.';

function createTooltip(tooltipOpts, target) {
Expand Down Expand Up @@ -96,7 +97,8 @@ describe('tooltip', () => {
{ name: 'dark-background-position-top', opts: { dark: true, content: longText, position: 'top' }, targetStyles: { left: mid, top: mid } },
{ name: 'dark-background-position-bottom', opts: { dark: true, content: longText, position: 'bottom', wrapped: true }, targetStyles: { left: mid, top: mid } },
{ name: 'dark-background-position-right', opts: { dark: true, content: longText, position: 'right' }, targetStyles: { left: mid, top: mid } },
{ name: 'dark-background-position-left', opts: { dark: true, content: longText, position: 'left', wrapped: true }, targetStyles: { left: mid, top: mid } }
{ name: 'dark-background-position-left', opts: { dark: true, content: longText, position: 'left', wrapped: true }, targetStyles: { left: mid, top: mid } },
{ name: 'long-text-wrap', opts: { content: longTextNoSpaces }, targetStyles: { left: mid, top: mid } }
].forEach(({ name, opts = {}, targetStyles = {}, rtl }) => {
it(name, async() => {
const elem = await fixture(createTooltip(opts, targetStyles), { rtl, viewport: { width: 400, height: 400 }, pagePadding: false });
Expand Down
1 change: 1 addition & 0 deletions components/tooltip/tooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ class Tooltip extends RtlMixin(LitElement) {
min-width: 2.1rem;
outline: ${outlineSize}px solid var(--d2l-tooltip-outline-color);
overflow: hidden;
overflow-wrap: anywhere;
padding: ${11 - contentBorderSize}px ${contentHorizontalPadding - contentBorderSize}px;
position: absolute;
}
Expand Down

0 comments on commit 30e69e6

Please sign in to comment.