Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Visual Diff Goldens for PR 2427 #2429

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 3, 2022

This pull request updates the visual-diff golden images for the changes in pull request #2427.

Please review the following failed reports closely before merging to ensure the visual differences are expected.

Failed Reports:

@github-actions github-actions bot requested a review from dlockhart May 3, 2022 15:48
@github-actions github-actions bot force-pushed the ghworkflow/visual-diff-pr-2427 branch 3 times, most recently from 544f643 to f605baf Compare May 3, 2022 18:52
@github-actions github-actions bot force-pushed the ghworkflow/visual-diff-pr-2427 branch from f605baf to 716ca1e Compare May 3, 2022 19:08
@dlockhart
Copy link
Member

@svanherk @dbatiste @margaree how do we feel about these 2 failing tests? I've tried for about 4 hours to get the scrolling to that element to work using different techniques and timeouts and while it works locally in my browser with everything I try, I keep coming up empty in visual-diff land. I'm out of ideas.

Interestingly, the exact same test in normal dialogs has been skipped for over a year... I'm guessing because it was similarly flakey or broken. I wonder if now that their CSS is aligned if they're both failing in the same way.

@svanherk
Copy link
Contributor

svanherk commented May 3, 2022

I'm fine with skipping/deleting, but out of curiosity did you try the capturebeyondViewport: false fix here? I wonder if that window resize is messing with it, although usually that does show up locally as well. But it's almost never let me down lol

@margaree
Copy link
Contributor

margaree commented May 3, 2022

Also fine with skipping these. If we want to potentially get them working one day, there's an issue opened for the other ones so we could add these to track them there #1127

@dbatiste
Copy link
Contributor

dbatiste commented May 3, 2022

It'd be nice to have them, but I'm in the camp of skipping it if the cost of reruns etc outweigh the value.

@github-actions github-actions bot closed this May 4, 2022
@github-actions github-actions bot deleted the ghworkflow/visual-diff-pr-2427 branch May 4, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants