Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip: Tooltip delay should be reset on close #5336

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

margaree
Copy link
Contributor

@margaree margaree commented Jan 21, 2025

Jira ticket

Requested by Jeff. He noticed that the current tooltip behaviour is that if a user is hovering over a tooltip target for > 1000ms and then goes to an adjacent target then there is a delay opening the next tooltip. We want the user to be able to quickly see the next tooltip contents if looking at a tooltip already, no matter how long they've been hovering over the current.

Desired behaviour:

  • No delay when user hovers over adjacent tooltip openers as long as they reach the adjacent opener within 1000ms (this is different than previous where if the user hovered for > 1000 ms there would be a delay on adjacent opener)
  • Delay on initial open (same as previous)
  • Delay on subsequent opens if 1000ms has passed and no other tooltip is open (same as previous)

@margaree margaree changed the title fix: tooltip: Tooltip delay should be reset on close [ignore for now] fix: tooltip: Tooltip delay should be reset on close Jan 21, 2025
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5336/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

@margaree margaree marked this pull request as ready for review January 22, 2025 13:42
@margaree margaree requested a review from a team as a code owner January 22, 2025 13:42
@margaree margaree changed the title [ignore for now] fix: tooltip: Tooltip delay should be reset on close fix: tooltip: Tooltip delay should be reset on close Jan 22, 2025
@margaree margaree merged commit db6c3da into main Jan 22, 2025
6 checks passed
@margaree margaree deleted the change-hover-delay branch January 22, 2025 15:07
Copy link

🎉 This PR is included in version 3.81.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants