Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate dark-light to v2 #250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025

This PR contains the following updates:

Package Type Update Change
dark-light dependencies major 1.1.1 -> 2.0.0

Release Notes

rust-dark-light/rust-dark-light (dark-light)

v2.0.0

Compare Source

We’re thrilled to announce the release of version 2.0.0! 🚀

After much hard work, testing, and listening to your feedback, this update brings exciting changes to the API, performance improvements, and a much needed addition, error management! We hope that this release fixes the issues that prevented many libraries from using this crate.

[!IMPORTANT]
Earlier this year, I proposed a feature for this library that would notify users when the theme changes. After several iterations, we developed a polished implementation specifically for FreeDesktop systems. Unfortunately, providing this functionality on other platforms proved challenging due platform specific limitations. After careful consideration, we decided not to pursue support for this feature. Instead, we are encouraging window creation libraries to take on this responsibility, ensuring a more seamless experience.

Breaking changes

This version brings breaking changes, the most important one being that dark_light::detect() now returns Result<Mode, Error>:

pub fn detect() -> Result<Mode, Error>;

dark-light is now capable of reporting issues during the attempt to detect the current Mode.

pub enum Error {
    /// If an I/O error occurs.
    Io(std::io::Error),
    /// If the XDG Desktop Portal could not be communicated with.
    XdgDesktopPortal(String),
    /// If the timeout is reached.
    Timeout,
    /// Failed to get persistent domain for Apple Global Domain.
    PersistentDomainFailed,
    /// If the window could not be found.
    WindowNotFound,
    /// If the media query could not be executed.
    MediaQueryFailed,
    /// If the media query is not supported.
    MediaQueryNotSupported,
}

We've also managed to close all issues, with only one remaining feature, maybe in our next release.

What's Changed

New Contributors

Full Changelog: rust-dark-light/dark-light@1.1.1...2.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants