feat: theme system #5619
feat: theme system #5619
Conversation
|
please explain in more detail what the "theme system" is, it already exists, doesn't it? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/kotlin/net/ccbluex/liquidbounce/integration/theme/ThemeManager.kt
Fixed
Show fixed
Hide fixed
| value = mutableListOf( | ||
| *theme.components | ||
| .filter { factory -> factory.default } | ||
| .map { factory -> factory.new(theme) }.toTypedArray() | ||
| ) |
Check warning
Code scanning / detekt
In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. Warning
| } | ||
|
|
||
| val matStack = MatrixStack() | ||
| override fun render(context: DrawContext, delta: Float) { |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
.../net/ccbluex/liquidbounce/integration/theme/themes/liquidbounce/routes/EmptyDrawableRoute.kt
Fixed
Show fixed
Hide fixed
| * | ||
| * @param jsonObject JsonObject | ||
| */ | ||
| private fun configureConfigurable(configurable: Configurable, jsonObject: JsonObject) { |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
| return@onChange enabled | ||
| } | ||
| val inbuiltThemes = arrayOf(LiquidBounceTheme) | ||
| var themes = mutableListOf<Theme>(*inbuiltThemes) |
Check warning
Code scanning / detekt
In most cases using a spread operator causes a full copy of the array to be created before calling a method. This may result in a performance penalty. Warning
| FontManager.queueFolder(folder.resolve("assets")) | ||
| } | ||
|
|
||
| override fun init() { } |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed. Warning
No description provided.