Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ElytraSwap #5625

Merged
merged 1 commit into from
Feb 15, 2025
Merged

refactor: ElytraSwap #5625

merged 1 commit into from
Feb 15, 2025

Conversation

ccetl
Copy link
Contributor

@ccetl ccetl commented Feb 14, 2025

  • Adds the alias "ChestSwap"
  • Makes the module disable after swapping
  • Makes the module not use broken elytras anymore
  • Makes the module conditionally remove an inventory action that is not always needed
  • Chestplate types are no longer defined manually (mod support & maintainability)

Copy link
Contributor

@sqlerrorthing sqlerrorthing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return back the 'key' setting

@ccetl
Copy link
Contributor Author

ccetl commented Feb 15, 2025

return back the 'key' setting

No I think it's bad design. Next this you want to do is add a bind into zoom?

@sqlerrorthing
Copy link
Contributor

return back the 'key' setting

No I think it's bad design. Next this you want to do is add a bind into zoom?

at least zoom makes the action "longer" than just changing this to this

@sqlerrorthing
Copy link
Contributor

and the module can be bound to hold and not to switch. in general, such a scenario does not fit in with me. if there is such a setting (key), then why not use it??

@1zun4 1zun4 merged commit fb5ff2e into CCBlueX:nextgen Feb 15, 2025
3 checks passed
@ccetl ccetl deleted the refactor-ChestSwap branch February 15, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants