Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test environment for PHP 5.6 and PHP 7.0 #3432

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add test environment for PHP 5.6 and PHP 7.0 #3432

wants to merge 6 commits into from

Conversation

Shelob9
Copy link
Collaborator

@Shelob9 Shelob9 commented Dec 23, 2019

Resolves #3431 by adding and documenting two new test sites in the local test environment

@Shelob9 Shelob9 added the PR (Patch) Is a pull request label Dec 23, 2019
@Shelob9 Shelob9 requested review from kjohnson and New0 December 23, 2019 15:50
New0
New0 reviewed Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@New0 New0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shelob9 the change here works but I think we didn't update composer commands to run yarn instead of npm in that case and would need to adapt nuke and dev:install commands, isn't it?

@Shelob9
Copy link
Collaborator Author

Shelob9 commented Jan 17, 2020

@New0 Yes, need updated to use yarn, not npm

@New0
Copy link
Collaborator

New0 commented Jan 30, 2020

@Shelob9 That is working for me but I wanted to know if there is a way to run PHP Unit tests selecting the environment?

@kjohnson kjohnson removed their request for review August 18, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@New0 New0 New0 left review comments

Assignees
No one assigned
Labels
PR (Patch) Is a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shelob9 @New0