Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle of Assorted Fixes #7015

Merged
merged 4 commits into from
Feb 15, 2025
Merged

Bundle of Assorted Fixes #7015

merged 4 commits into from
Feb 15, 2025

Conversation

Jetz72
Copy link
Contributor

@Jetz72 Jetz72 commented Feb 14, 2025

Small handful of minor fixes and changes.

  • Fix importing when the last few letters of the card name are also a set code. Closes Import Parses Tyrannax Rex Incorrectly #5941.
  • Add text formatting support for "[Keyword]cycling" and "Affinity for [Keyword]". Not really perfect since the reminder text for the former still comes out as "for a [keyword] card" instead of "for a card with [keyword]", but the text formatting there hooks into several other keywords so this seems acceptable for now. Unblocks DA1: Sojourner's Enforcermite #7003.
  • "Number of attractions you visited this turn" now counts attractions that have left the battlefield or have stopped being Attractions, per rule 608.2i. Doesn't close any issues because it's a niche rule in an edge case scenario involving multiple cards from a pool that are almost never used... but it's been bugging me so here it is.
  • Remove the wake lock code for desktop. Java does not offer any proper API for this functionality, so it worked by simulating a key press of "F15" every 30 seconds or so. It was written with the assumption that the F15 key would typically never have any effect, but that assumption has not held up. We could replace it with a different solution that simulates a mouse jitter, but I'd like to try removing it completely first. Desktop OSes like Windows are a bit less strict about sleep conditions than Android, and it's possible the network traffic will be enough to keep the CPU awake. If anyone objects, or if we encounter any issues caused by this in the future, I don't mind implementing an alternative. Closes Issue with Forge causing undesirable/destabilizing effects on linux distros #4678 and properly closes Loose control of keyboard #3485.

@Jetz72 Jetz72 added Rules compliance Bringing the engine or cards closer to CR Desktop labels Feb 14, 2025
Copy link
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your reasoning :)

@Hanmac Hanmac merged commit 3af6288 into Card-Forge:master Feb 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Desktop Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
3 participants