Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make profiles type stable #39

Closed
wants to merge 1 commit into from
Closed

Make profiles type stable #39

wants to merge 1 commit into from

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Aug 10, 2023

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8808529) 100.00% compared to head (6a11c42) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          252       252           
=========================================
  Hits           252       252           
Files Changed Coverage Δ
src/profiles/ARM_SGP.jl 100.00% <100.00%> (ø)
src/profiles/DryBubble.jl 100.00% <100.00%> (ø)
src/profiles/Dycoms_RF01.jl 100.00% <100.00%> (ø)
src/profiles/GABLS.jl 100.00% <100.00%> (ø)
src/profiles/GATE_III.jl 100.00% <100.00%> (ø)
src/profiles/LifeCycleTan2018.jl 100.00% <100.00%> (ø)
src/profiles/Nieuwstadt.jl 100.00% <100.00%> (ø)
src/profiles/Rico.jl 100.00% <100.00%> (ø)
src/profiles/Soares.jl 100.00% <100.00%> (ø)
src/profiles/TRMM_LBA.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charleskawczynski
Copy link
Member

I think the upstream issue is maybe JuliaMath/Dierckx.jl#48?

we could alternatively try to fix it there

@szy21
Copy link
Member Author

szy21 commented Aug 11, 2023

I think the upstream issue is maybe kbarbary/Dierckx.jl#48?

we could alternatively try to fix it there

Does it seem like something we can fix easily? cc @simonbyrne This is what I mentioned briefly this morning.

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess there are more qualified people thinking about how to fix it in Dierckx

@charleskawczynski
Copy link
Member

Superseded by #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants