non blocking output reader #1521
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this catch jvm crashes? |
Catches invalid jvm arguments Also catches everything in a shutdown hook |
DasBabyPixel
force-pushed
the
non-blocking-output-reading
branch
from
adcd07b to
8afcbef
Compare
|
May have some issues after considerable changes, I'm going to use this in my build first and if I think it is stable, I'm going to mark this ready for review. |
DasBabyPixel
force-pushed
the
non-blocking-output-reading
branch
from
cc73ac4 to
ae9e900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Logging had some issues with blocking when a full line wasn't written in output.
Modification
Fixed those issues by implementing a custom readLine() which calls ready() before every read()
Result
Logging works with the new system (and very little delay, which is very nice, as opposed to 1 second polling alternative)
Other context
@0utplay or @GiantTreeLP please review this derklaro is fed up with this problem
Still based on the old logging to better highlight modifications. This is the reason why this is a conflict
As soon as this is reviewed I can rebase/merge and revert the revered new logging system to make this mergeable