-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change peer dependency version, one type fix and add langgraph in ts docs #1209
base: master
Are you sure you want to change the base?
Conversation
🚀 Code Review Initiated The review process for this pull request has started. Our system is analyzing the changes for:
You will receive structured and actionable feedback shortly! ⏳ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 12ab9dd in 30 seconds
More details
- Looked at
87
lines of code in4
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/package.json:57
- Draft comment:
Avoid using*
for versioning in dependencies. Specify a version range forresolve-package-path
to ensure compatibility. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_WDGjhbAAg301jl6Q
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
"@langchain/openai": ">0.2.0", | ||
"langchain": ">0.2.0", | ||
"openai": ">4.0", | ||
"resolve-package-path": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using *
for versioning in peer dependencies. Specify a version range for resolve-package-path
to ensure compatibility.
…io into ft-change-dist-version
"ai": "^3.2.22", | ||
"langchain": "^0.2.11", | ||
"openai": "^4.50.0" | ||
"ai": ">3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using >
version constraints for peer dependencies could lead to unexpected compatibility issues if major versions introduce breaking changes. Consider:
- Using
^
for minor version flexibility while preventing major version jumps - Using more specific ranges like
>4.0.0 <5.0.0
- Documenting the testing strategy for version compatibility
@@ -35,7 +35,8 @@ export type RawActionData = z.infer<typeof ZRawActionSchema>; | |||
This is the schema for the params object in the ExecuteAction function | |||
*/ | |||
export const ZExecuteActionParams = z.object({ | |||
action: z.string(), | |||
action: z.string().optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making both action
and actionName
optional could lead to cases where neither is provided. Consider:
- Adding a Zod refinement to ensure at least one is provided
- Adding JSDoc comments to explain the usage and deprecation
- Adding validation in the schema level rather than just in the implementation
Example:
export const ZExecuteActionParams = z.object({
action: z.string().optional().deprecated(),
actionName: z.string().optional(),
// ...
}).refine(
data => data.action || data.actionName,
{ message: "Either action or actionName must be provided" }
);
Review SummaryChanges Overview
Concerns and Suggestions
Code Quality: 7/10
The changes appear well-structured but need additional safeguards around type safety and version management. Consider implementing the suggested improvements before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 9813885 in 22 seconds
More details
- Looked at
43
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/src/sdk/models/integrations.ts:4
- Draft comment:
The import forDeleteRowAPIDTO
is removed, but ensure that it is not used elsewhere in the codebase to avoid reference errors. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Y8ell52pUIeDC9LV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…io into ft-change-dist-version
Important
Update peer dependency versions, modify type definitions, and add
langgraph
to TypeScript documentation.package.json
andpackage.dist.json
to broader ranges forai
,@ai-sdk/openai
,@cloudflare/workers-types
,@langchain/core
,@langchain/openai
,langchain
, andopenai
.resolve-package-path
as a peer dependency.IntegrationDeleteRes
type inintegrations.ts
to includesuccessful
andintegrationId
fields.ZExecuteActionParams
inbase_toolset.ts
to include optionalactionName
.src/frameworks/langgraph.ts
totypedoc.json
entry points.This description was created by
for 9813885. It will automatically update as commits are pushed.