Cruikshanks latest changes to the view return log #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
force-pushed
the
alans-latest-update
branch
4 times, most recently
from
153272b to
817aefa
Compare
https://eaflood.atlassian.net/browse/WATER-4745 > See [Create Completed Monthly Return Logs page](#1484) > Will not work until `main` is merged into `new-view-completed-monthly-return-logs-page` The following changes are included - switch to existing status macro and remove duplicate - set correct status in presenter - update versions design (add 'Version x' as a line and prefix with 'Viewing ' for selected version) - add received date to the metadata - update all return log links to go to view page - update Edit return to be Edit or Submit return (depending on return log status) - update page to handle viewing _any_ return log, including 'due' and 'received' which have no submission data
Cruikshanks
force-pushed
the
alans-latest-update
branch
from
a4d17be to
a1ac0ef
Compare
Came back in after the rebase!
StuAA78
merged commit 80deedb
into
new-view-completed-monthly-return-logs-page
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4745
The following changes are included